fixes in stringImproved #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* single char variant now calls the string_view counterpart (ensures consistency) * fixed the `find` which was using the stock `substr()` and not the improved string ones, which has a different behavior (mostly about negative indices).
gcask
commented
Jul 1, 2021
| @@ -146,7 +151,7 @@ class string : public std::string | |||
| } | |||
| bool endswith(char suffix) const | |||
| { | |||
| return !empty() && (*this)[length()-1] == suffix; | |||
There was a problem hiding this comment.
This is interesting, because it meant that string{}.endswith("") != string{}.endswith('\0') (the string version assumes an empty string is always present at the end of a string)
|
Note: we should make more stuff use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findwhich was using the stocksubstr()and not the improved string ones, which has a different behavior (mostly about negative indices).