Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings for DailyCallOptions & join #165

Closed
wants to merge 2 commits into from
Closed

Fix typings for DailyCallOptions & join #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebbee8b
index.d.ts: fix DailyCallOptions, join() typings
kwshi May 20, 2021
563878b
keep string in videoSource/audioSource
kwshi May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 44 additions & 44 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ export interface DailyCallOptions {
cssText?: string;
dailyConfig?: DailyAdvancedConfig;
subscribeToTracksAutomatically?: boolean;
videoSource?: string | MediaStreamTrack;
audioSource?: string | MediaStreamTrack;
videoSource?: boolean | string | MediaStreamTrack;
audioSource?: boolean | string | MediaStreamTrack;
userName?: string;
}

export interface DailyLoadOptions extends DailyCallOptions {
Expand Down Expand Up @@ -522,47 +523,46 @@ export interface DailyEventObjectLangUpdated {
langSetting: DailyLanguageSetting;
}

export type DailyEventObject<
T extends DailyEvent = any
> = T extends DailyEventObjectAppMessage['action']
? DailyEventObjectAppMessage
: T extends DailyEventObjectNoPayload['action']
? DailyEventObjectNoPayload
: T extends DailyEventObjectCameraError['action']
? DailyEventObjectCameraError
: T extends DailyEventObjectFatalError['action']
? DailyEventObjectFatalError
: T extends DailyEventObjectGenericError['action']
? DailyEventObjectGenericError
: T extends DailyEventObjectParticipants['action']
? DailyEventObjectParticipants
: T extends DailyEventObjectParticipant['action']
? DailyEventObjectParticipant
: T extends DailyEventObjectWaitingParticipant['action']
? DailyEventObjectWaitingParticipant
: T extends DailyEventObjectAccessState['action']
? DailyEventObjectAccessState
: T extends DailyEventObjectMeetingSessionUpdated['action']
? DailyEventObjectMeetingSessionUpdated
: T extends DailyEventObjectTrack['action']
? DailyEventObjectTrack
: T extends DailyEventObjectRecordingStarted['action']
? DailyEventObjectRecordingStarted
: T extends DailyEventObjectMouseEvent['action']
? DailyEventObjectMouseEvent
: T extends DailyEventObjectTouchEvent['action']
? DailyEventObjectTouchEvent
: T extends DailyEventObjectNetworkQualityEvent['action']
? DailyEventObjectNetworkQualityEvent
: T extends DailyEventObjectNetworkConnectionEvent['action']
? DailyEventObjectNetworkConnectionEvent
: T extends DailyEventObjectActiveSpeakerChange['action']
? DailyEventObjectActiveSpeakerChange
: T extends DailyEventObjectActiveSpeakerModeChange['action']
? DailyEventObjectActiveSpeakerModeChange
: T extends DailyEventObjectLangUpdated['action']
? DailyEventObjectLangUpdated
: any;
export type DailyEventObject<T extends DailyEvent = any> =
T extends DailyEventObjectAppMessage['action']
? DailyEventObjectAppMessage
: T extends DailyEventObjectNoPayload['action']
? DailyEventObjectNoPayload
: T extends DailyEventObjectCameraError['action']
? DailyEventObjectCameraError
: T extends DailyEventObjectFatalError['action']
? DailyEventObjectFatalError
: T extends DailyEventObjectGenericError['action']
? DailyEventObjectGenericError
: T extends DailyEventObjectParticipants['action']
? DailyEventObjectParticipants
: T extends DailyEventObjectParticipant['action']
? DailyEventObjectParticipant
: T extends DailyEventObjectWaitingParticipant['action']
? DailyEventObjectWaitingParticipant
: T extends DailyEventObjectAccessState['action']
? DailyEventObjectAccessState
: T extends DailyEventObjectMeetingSessionUpdated['action']
? DailyEventObjectMeetingSessionUpdated
: T extends DailyEventObjectTrack['action']
? DailyEventObjectTrack
: T extends DailyEventObjectRecordingStarted['action']
? DailyEventObjectRecordingStarted
: T extends DailyEventObjectMouseEvent['action']
? DailyEventObjectMouseEvent
: T extends DailyEventObjectTouchEvent['action']
? DailyEventObjectTouchEvent
: T extends DailyEventObjectNetworkQualityEvent['action']
? DailyEventObjectNetworkQualityEvent
: T extends DailyEventObjectNetworkConnectionEvent['action']
? DailyEventObjectNetworkConnectionEvent
: T extends DailyEventObjectActiveSpeakerChange['action']
? DailyEventObjectActiveSpeakerChange
: T extends DailyEventObjectActiveSpeakerModeChange['action']
? DailyEventObjectActiveSpeakerModeChange
: T extends DailyEventObjectLangUpdated['action']
? DailyEventObjectLangUpdated
: any;

export interface DailyFaceInfo {
score: number;
Expand Down Expand Up @@ -627,7 +627,7 @@ export type DailyAccessRequest = {

export interface DailyCall {
iframe(): HTMLIFrameElement | null;
join(properties?: DailyCallOptions): Promise<DailyParticipantsObject | void>;
join(properties?: DailyCallOptions): Promise<DailyParticipantsObject>;
leave(): Promise<void>;
destroy(): Promise<void>;
loadCss(properties: {
Expand Down