chore: add error message when using custom iframe without right allow value #190
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanoander
force-pushed
the
add_error_msg_for_custom_iframe_without_allow
branch
from
7603b67 to
75aa72e
Compare
|
Thanks for the review AND the patch! We'll get someone to take a look shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
@daily-co/daily-jsfor a POC as a possible replacement of Twilio.I quickly got it running by using my own
<iframe />(usingwrap(), notcreateFrame()), but I was seeing a message asking to allow mic and camera in the browser, even though the permissions were properly set already.I opened the dev tools, but couldn't easily find what was happening.
Then, comparing my iframe with the one created by
createFrame(), I realized my iframe was lacking theallowproperty with the right permissions.This PR is a proposal contribution to make the developer's experience more straightforward in cases like this.