Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal : alternative pom to build jre with remote debugging capabilites #222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Proposal : alternative pom to build jre with remote debugging capabilites #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
403df1d
Add jdk.jdwp.agent for debugging
NPavie Nov 22, 2023
2a0cd95
Remove duplication and rename DEV to FOR_DEBUGGING
bertfrees Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,25 +465,40 @@ endif
ifeq ($(OS), MACOSX)
-Pbuild-jre-linux -Pbuild-jre-win32 -Pbuild-jre-win64 -Pbuild-jre-mac : src/main/jre/OpenJDK17U-jdk_x64_mac_hotspot_17.0.7_7/jdk-17.0.7+7
ifndef DUMP_PROFILES
rm("target/classes"); \
rm("target/classes");
ifdef FOR_DEBUGGING
exec(env("JAVA_HOME", "$(CURDIR)/$</Contents/Home"), \
"$(MVN)", "-f", "build-jre.xml", "jlink:jlink", "$@", "-Pinclude-jdwp-agent");
else
exec(env("JAVA_HOME", "$(CURDIR)/$</Contents/Home"), \
"$(MVN)", "-f", "build-jre.xml", "jlink:jlink", "$@");
endif # FOR_DEBUGGING
endif
else ifeq ($(OS), WINDOWS)
-Pbuild-jre-linux -Pbuild-jre-win32 -Pbuild-jre-win64 : src/main/jre/OpenJDK17U-jdk_x64_windows_hotspot_17.0.7_7/jdk-17.0.7+7
ifndef DUMP_PROFILES
rm("target/classes"); \
rm("target/classes");
ifdef FOR_DEBUGGING
exec(env("JAVA_HOME", "$(CURDIR)/$<"), \
"$(MVN)", "-f", "build-jre.xml", "jlink:jlink", "$@", "-Pinclude-jdwp-agent");
else
exec(env("JAVA_HOME", "$(CURDIR)/$<"), \
"$(MVN)", "-f", "build-jre.xml", "jlink:jlink", "$@");
endif
endif
else
-Pbuild-jre-linux -Pbuild-jre-win32 -Pbuild-jre-win64 : src/main/jre/OpenJDK17U-jdk_x64_linux_hotspot_17.0.7_7/jdk-17.0.7+7
ifndef DUMP_PROFILES
rm("target/classes"); \
rm("target/classes");
ifdef FOR_DEBUGGING
exec(env("JAVA_HOME", "$(CURDIR)/$<"), \
"$(MVN)", "-f", "build-jre.xml", "jlink:jlink", "$@", "-Pinclude-jdwp-agent");
else
exec(env("JAVA_HOME", "$(CURDIR)/$<"), \
"$(MVN)", "-f", "build-jre.xml", "jlink:jlink", "$@");
endif
endif
endif

# for dependencies to jmods
-Pbuild-jre-mac : src/main/jre/OpenJDK17U-jdk_x64_mac_hotspot_17.0.7_7/jdk-17.0.7+7
Expand Down
17 changes: 17 additions & 0 deletions build-jre.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,23 @@
</pluginManagement>
</build>
<profiles>
<profile>
<id>include-jdwp-agent</id>
<build>
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-jlink-plugin</artifactId>
<configuration>
<addModules combine.children="append">
<addModule>jdk.jdwp.agent</addModule>
</addModules>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</profile>
<profile>
<id>build-jre-linux</id>
<!--
Expand Down
Loading