Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to filter player stats by event type and date #89

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

hnjpedro
Copy link

@hnjpedro hnjpedro commented Sep 28, 2022

Also edited README.md to show how requests should be made now.

This is also my first pull request ever, so if I'm doing anything wrong, just let me know :)

@vercel
Copy link

vercel bot commented Sep 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hltv-api ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 3:56AM (UTC)

@vercel vercel bot temporarily deployed to Preview September 28, 2022 19:41 Inactive
Changed the order of the response. Now, it also returns two different arrays: one for stats and for player data, including team logo
@vercel vercel bot temporarily deployed to Preview October 4, 2022 16:39 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 17:39 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 18:25 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 18:56 Inactive
@vercel vercel bot temporarily deployed to Preview October 4, 2022 20:52 Inactive
@hnjpedro
Copy link
Author

hnjpedro commented Oct 4, 2022

Initial PR had a problem with the TS files. Sorry about that. Should be fixed now!

@vercel vercel bot temporarily deployed to Preview October 5, 2022 01:14 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 00:36 Inactive
@dajk
Copy link
Owner

dajk commented Nov 12, 2022

Hey @hnjpedro ,

Thanks for contributing!

How useful is to have that since eventId is not something we know from anywhere. How would one know which id to pass?

@hnjpedro hnjpedro changed the title Added ability to filter player stats by event type Added ability to filter player stats by event type and date Nov 12, 2022
@hnjpedro
Copy link
Author

Hey @hnjpedro ,

Thanks for contributing!

How useful is to have that since eventId is not something we know from anywhere. How would one know which id to pass?

Wouldn't adding the possible matchTypes to the README.md file be enough? I added some of them, but not all.
I'm still fairly new to this, so I don't know if this is bad practice.

The event/match types are the same as the HLTV uses, though (Majors, BigEvents, Online, etc.), which I think is fair to assume most people who are interested in this API are familiar with.

This PR also allows users to search by date, although I'm not sure this should have been on an entirely different PR.

If you want an example, you can check this out: http://htmlpreview.github.io/?https://github.com/hnjpedro/hltvhead2head/master/index.html

@vercel vercel bot temporarily deployed to Preview November 12, 2022 03:19 Inactive
@dajk
Copy link
Owner

dajk commented Nov 13, 2022

Hey @hnjpedro ,
Thanks for contributing!
How useful is to have that since eventId is not something we know from anywhere. How would one know which id to pass?

Wouldn't adding the possible matchTypes to the README.md file be enough? I added some of them, but not all. I'm still fairly new to this, so I don't know if this is bad practice.

The event/match types are the same as the HLTV uses, though (Majors, BigEvents, Online, etc.), which I think is fair to assume most people who are interested in this API are familiar with.

This PR also allows users to search by date, although I'm not sure this should have been on an entirely different PR.

If you want an example, you can check this out: http://htmlpreview.github.io/?https://github.com/hnjpedro/hltvhead2head/master/index.html

Ok, makes sense, I think I mixed that with something else.

I can see that you are introducing too few breaking changes (player interface), please keep your pull request minimal, revert all the configuration file changes (e.g. package.json)..

@vercel vercel bot temporarily deployed to Preview November 14, 2022 03:56 Inactive
@hnjpedro
Copy link
Author

Hey @hnjpedro ,
Thanks for contributing!
How useful is to have that since eventId is not something we know from anywhere. How would one know which id to pass?

Wouldn't adding the possible matchTypes to the README.md file be enough? I added some of them, but not all. I'm still fairly new to this, so I don't know if this is bad practice.
The event/match types are the same as the HLTV uses, though (Majors, BigEvents, Online, etc.), which I think is fair to assume most people who are interested in this API are familiar with.
This PR also allows users to search by date, although I'm not sure this should have been on an entirely different PR.
If you want an example, you can check this out: http://htmlpreview.github.io/?https://github.com/hnjpedro/hltvhead2head/master/index.html

Ok, makes sense, I think I mixed that with something else.

I can see that you are introducing too few breaking changes (player interface), please keep your pull request minimal, revert all the configuration file changes (e.g. package.json)..

Hey!
I've reverted the changes to package.json. These were accidental.

Do you think I should make any additional changes to the other files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants