-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to filter player stats by event type and date #89
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Changed the order of the response. Now, it also returns two different arrays: one for stats and for player data, including team logo
Initial PR had a problem with the TS files. Sorry about that. Should be fixed now! |
Hey @hnjpedro , Thanks for contributing! How useful is to have that since |
Wouldn't adding the possible matchTypes to the README.md file be enough? I added some of them, but not all. The event/match types are the same as the HLTV uses, though (Majors, BigEvents, Online, etc.), which I think is fair to assume most people who are interested in this API are familiar with. This PR also allows users to search by date, although I'm not sure this should have been on an entirely different PR. If you want an example, you can check this out: http://htmlpreview.github.io/?https://github.com/hnjpedro/hltvhead2head/master/index.html |
Ok, makes sense, I think I mixed that with something else. I can see that you are introducing too few breaking changes (player interface), please keep your pull request minimal, revert all the configuration file changes (e.g. package.json).. |
Hey! Do you think I should make any additional changes to the other files? |
Also edited README.md to show how requests should be made now.
This is also my first pull request ever, so if I'm doing anything wrong, just let me know :)