Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEON backend for aarch64 #457

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

NEON backend for aarch64 #457

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cdffbbd
Added ARM neon backend support
Oct 27, 2022
13b52a0
Use packed_simd::shuffle instead of vqtbx1q_u8
rubdos Dec 7, 2022
14e05d4
Use shuffle! macro instead of manual lane swapping in FieldElement262…
rubdos Dec 8, 2022
58a853d
Rustfmt: retain some manual formatting
rubdos Dec 14, 2022
c49e465
rustfmt on neon constants
rubdos Dec 14, 2022
38807d0
implemented packed_simd for neon
Tarinn Mar 1, 2024
d2b7b31
fixed minor mistake
Tarinn Mar 22, 2024
1c070b3
Small improvements to neon backend
Tarinn May 22, 2024
f61eb5a
repack_pair optimisation
Tarinn Jun 3, 2024
6cffc06
fixed small bug in repack_pair
Tarinn Jun 3, 2024
b7d2f53
changed to use internal arm types instead of tuples
Tarinn Jun 6, 2024
d524791
further refactoring to internal arm types
Tarinn Aug 21, 2024
5c15111
Merge remote-tracking branch 'origin/main' into dalek-neon
rubdos Aug 21, 2024
2aa38c9
Clippy
rubdos Aug 21, 2024
98d09ae
Rustfmt
rubdos Aug 21, 2024
7921293
Simplify packed_simd constructors
rubdos Jan 20, 2025
4c1b6ae
Removed warnings and use vld* for non-const new and splat functions i…
Tarinn Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use packed_simd::shuffle instead of vqtbx1q_u8
  • Loading branch information
@rubdos
rubdos committed Feb 28, 2024
commit 13b52a09444215da1fc2e46bb475848e3bdeddfb
59 changes: 26 additions & 33 deletions curve25519-dalek/src/backend/vector/neon/field.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,40 +211,33 @@ impl FieldElement2625x4 {
pub fn blend(&self, other: FieldElement2625x4, control: Lanes) -> FieldElement2625x4 {
#[inline(always)]
fn blend_lanes(x: (u32x4, u32x4), y: (u32x4, u32x4), control: Lanes) -> (u32x4, u32x4) {
unsafe {
use core::arch::aarch64::vqtbx1q_u8;
match control {
Lanes::C => {
(x.0,
vqtbx1q_u8(x.1.into_bits(), y.1.into_bits(), u8x16::new( 0, 1, 2, 3, 16, 16, 16, 16, 8, 9, 10, 11, 16, 16, 16, 16).into_bits()).into_bits())
}
Lanes::D => {
(x.0,
vqtbx1q_u8(x.1.into_bits(), y.1.into_bits(), u8x16::new(16, 16, 16, 16, 4, 5, 6, 7, 16, 16, 16, 16, 12, 13, 14, 15).into_bits()).into_bits())
}
Lanes::AD => {
(vqtbx1q_u8(x.0.into_bits(), y.0.into_bits(), u8x16::new( 0, 1, 2, 3, 16, 16, 16, 16, 8, 9, 10, 11, 16, 16, 16, 16).into_bits() ).into_bits(),
vqtbx1q_u8(x.1.into_bits(), y.1.into_bits(), u8x16::new(16, 16, 16, 16, 4, 5, 6, 7, 16, 16, 16, 16, 12, 13, 14, 15).into_bits() ).into_bits())
}
Lanes::AB => {
(y.0, x.1)
}
Lanes::AC => {
(vqtbx1q_u8(x.0.into_bits(), y.0.into_bits(), u8x16::new( 0, 1, 2, 3, 16, 16, 16, 16, 8, 9, 10, 11, 16, 16, 16, 16).into_bits()).into_bits(),
vqtbx1q_u8(x.1.into_bits(), y.1.into_bits(), u8x16::new( 0, 1, 2, 3, 16, 16, 16, 16, 8, 9, 10, 11, 16, 16, 16, 16).into_bits()).into_bits())
}
Lanes::CD => {
(x.0, y.1)
}
Lanes::BC => {
(vqtbx1q_u8(x.0.into_bits(), y.0.into_bits(), u8x16::new(16, 16, 16, 16, 4, 5, 6, 7, 16, 16, 16, 16, 12, 13, 14, 15).into_bits() ).into_bits(),
vqtbx1q_u8(x.1.into_bits(), y.1.into_bits(), u8x16::new( 0, 1, 2, 3, 16, 16, 16, 16, 8, 9, 10, 11, 16, 16, 16, 16).into_bits() ).into_bits())
}
Lanes::ABCD => {
y
}

use packed_simd::shuffle;
match control {
Lanes::C => {
(x.0, shuffle!(y.1, x.1, [0, 5, 2, 7]))
}
Lanes::D => {
(x.0, shuffle!(y.1, x.1, [4, 1, 6, 3]))
}
Lanes::AD => {
(shuffle!(y.0, x.0, [0, 5, 2, 7]), shuffle!(y.1, x.1, [4, 1, 6, 3]))
}
Lanes::AB => {
(y.0, x.1)
}
Lanes::AC => {
(shuffle!(y.0, x.0, [0, 5, 2, 7]), shuffle!(y.1, x.1, [0, 5, 2, 7]))
}
Lanes::CD => {
(x.0, y.1)
}
Lanes::BC => {
(shuffle!(y.0, x.0, [4, 1, 6, 3]), shuffle!(y.1, x.1, [0, 5, 2, 7]))
}
Lanes::ABCD => {
y
}

}
}

Expand Down