Lint major changes and plugin tests pass with npm test

.editorconfig

@@ -9,12 +9,12 @@ charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
-[*.md]
+[*.{eslintrc,md}]
 trim_trailing_whitespace = false
 indent_style = tab
 indent_size = 4
 
-[*.xml]
+[*.{html,xml}]
 trim_trailing_whitespace = false
 indent_style = tab
 indent_size = 2

plugins/.eslintrc

@@ -0,0 +1,6 @@
+{
+    "extends": "airbnb-base",
+    "rules": {
+        "max-len": [2, 150, 4]
+    }
+}

plugins/exists/lib/index.js

@@ -1,27 +1,37 @@
-'use strict';
+const boom = require('boom');
+const fs = require('fs');
+const path = require('path');
+
+const moduleName = 'pathExists';
+
 /**
 Verify if a path exists on the file system
 
 @method pathExists
-@param {string} path relative/absolute path (file or folder) on the file system
-@param {promise}
+@param {string} verifyPath relative/absolute path (file or folder) on the file system
+@returns {promise}
 **/
 function pathExists(verifyPath) {
   return new Promise((resolve, reject) => {
-    const boom = require('boom');
     if (verifyPath === undefined) {
-      reject(boom.notFound(`pathExists module: is missing a path to verify`));
+      reject(boom.notFound(`${moduleName} module: File system path is missing (${verifyPath})`));
     }
-    const verifiedPath = require('path').isAbsolute(verifyPath) ?
-      verifyPath : require('app-root-path').resolve(verifyPath);
 
-    require('fs').stat(verifiedPath, (error, type) => {
+    const verifiedPath = path.isAbsolute(verifyPath) ? verifyPath : path.resolve('../', verifyPath);
+
+    fs.stat(verifiedPath, (error, type) => {
       if (error) {
-        return reject(boom.notFound(`pathExists module: File system path is missing ${error}`));
+        const pathType = path.isAbsolute(verifyPath) ? 'absolute' : 'relative';
+
+        return reject(boom.notFound(`${moduleName} module: File system path is ${pathType} and not found
+        due to error (${error})`));
       }
+
       if (type.isFile() || type.isDirectory()) {
         return resolve(verifiedPath);
       }
+
+      return reject(boom.notFound('File failed'));
     });
   });
 }

plugins/exists/test/index.js

@@ -1,80 +1,77 @@
-'use strict';
-const test = require('tape');
+const tape = require('tape-catch');
 
-test('Real relative file exists', (assert) => {
-  const module = require('../lib');
-  const testPath = './plugins/exists/test/fixtures/exists.txt';
+tape('Index', { skip: false }, (describe) => {
+  const path = require('path');
 
-  module.pathExists(testPath)
-    .then(() => {
-      assert.pass('Resolved promise is returned');
-      assert.end();
-    })
-    .catch(() => {
-      assert.fail(`File system is missing folder (${testPath})`);
-      assert.end();
-    });
-});
+  const lib = require('../lib');
 
-test('Real relative folder exists', (assert) => {
-  const module = require('../lib');
-  const testPath = './plugins/exists/test/fixtures';
+  describe.test('* Real relative file exists', (assert) => {
+    const testPath = './plugins/exists/test/fixtures/exists.txt';
 
-  module.pathExists(testPath)
-    .then(() => {
-      assert.pass('Resolved promise is returned');
-      assert.end();
-    })
-    .catch(() => {
-      assert.fail(`File system is missing folder (${testPath})`);
-      assert.end();
-    });
-});
+    lib.pathExists(testPath)
+      .then(() => {
+        assert.pass('Resolved promise is returned');
+        assert.end();
+      })
+      .catch((error) => {
+        assert.fail(error);
+        assert.end();
+      });
+  });
 
-test('Real absolute file exists', (assert) => {
-  const module = require('../lib');
-  const path = require('path');
-  const testPath = path.join(__dirname, './fixtures/exists.txt');
+  describe.test('* Real relative folder exists', (assert) => {
+    const testPath = './plugins/exists/test/fixtures';
 
-  module.pathExists(testPath)
-    .then((verifiedPath) => {
-      assert.equal(verifiedPath, testPath, 'Resolved path matches');
-      assert.end();
-    })
-    .catch(() => {
-      assert.fail(`File system is missing folder (${testPath})`);
-      assert.end();
-    });
-});
+    lib.pathExists(testPath)
+      .then(() => {
+        assert.pass('Resolved promise is returned');
+        assert.end();
+      })
+      .catch((error) => {
+        assert.fail(error);
+        assert.end();
+      });
+  });
 
-test('Real absolute folder exists', (assert) => {
-  const module = require('../lib');
-  const path = require('path');
-  const testPath = path.join(__dirname, './fixtures');
+  describe.test('* Real absolute file exists', (assert) => {
+    const testPath = path.join(__dirname, './fixtures/exists.txt');
 
-  module.pathExists(testPath)
-    .then((verifiedPath) => {
-      assert.equal(verifiedPath, testPath, 'Resolved path matches');
-      assert.end();
-    })
-    .catch(() => {
-      assert.fail(`File system is missing folder (${testPath})`);
-      assert.end();
-    });
-});
+    lib.pathExists(testPath)
+      .then((verifiedPath) => {
+        assert.equal(verifiedPath, testPath, 'Resolved path matches');
+        assert.end();
+      })
+      .catch((error) => {
+        assert.fail(error);
+        assert.end();
+      });
+  });
 
-test('Fake absolute path does not exists', (assert) => {
-  const module = require('../lib');
-  const path = require('path');
-  const testPath = path.join(__dirname, './fixtures/fakeFolder');
+  describe.test('* Real absolute folder exists', (assert) => {
+    const testPath = path.join(__dirname, './fixtures');
+
+    lib.pathExists(testPath)
+      .then((verifiedPath) => {
+        assert.equal(verifiedPath, testPath, 'Resolved path matches');
+        assert.end();
+      })
+      .catch((error) => {
+        assert.fail(error);
+        assert.end();
+      });
+  });
+
+  describe.test('* Fake absolute path does not exists', (assert) => {
+    const testPath = path.join(__dirname, './fixtures/fakeFolder');
 
-  module.pathExists(testPath)
-    .then(() => {
-      assert.fail(`File system found a fake folder (${testPath})`);
-      assert.end();
-    })
-    .catch((error) => {
-      assert.equal(error.isBoom, true, 'Rejected promise is a boom error');
-      assert.end();
-    });
+    lib.pathExists(testPath)
+      .then(() => {
+        assert.fail(`File system found a fake folder (${testPath})`);
+        assert.end();
+      })
+      .catch((error) => {
+        assert.equal(error.isBoom, true, 'Rejected promise is a boom error');
+        assert.end();
+      });
+  });
 });

plugins/dev-mode/shared-gulpfile.js → plugins/gulpfile.js

@@ -1,25 +1,37 @@
-const gulp = require('gulp');
 const eslint = require('gulp-eslint');
 const expect = require('gulp-expect-file');
+const gulp = require('gulp');
+const print = require('gulp-print');
 const tape = require('gulp-tape');
 
 const paths = {
-  scripts: ['../../lib/**/*.js'],
-  test: ['../../test/**/*.js']
+  lib: [
+    'exists/lib/*.js',
+    'rename/lib/*.js'
+  ],
+  test: [
+    'exists/test/*.js',
+    'rename/test/*.js'
+  ]
 };
 
-gulp.task('lint', () => {
-  const files = paths.scripts.concat(paths.test);
+function lint(files, configFile) {
   return gulp.src(files)
+    .pipe(print())
     .pipe(expect(files))
-    .pipe(eslint({ configFile: '.eslintrc.json' }))
+    .pipe(eslint({ configFile }))
     .pipe(eslint.format())
     .pipe(eslint.failAfterError());
-});
+}
+
+gulp.task('lint', ['lint-test'], () => lint(paths.lib, '.eslintrc'));
+gulp.task('lint-test', () => lint(paths.test, 'test.eslintrc'));
 
 gulp.task('test', () => {
   const files = paths.test;
+
   return gulp.src(files)
+    .pipe(print())
     .pipe(expect(files))
     .pipe(tape());
 });

plugins/package.json

@@ -0,0 +1,44 @@
+{
+  "name": "history-plugins",
+  "version": "1.1.10",
+  "description": "Developer dependencies for history plugins",
+  "main": "gulpfile.js",
+  "scripts": {
+    "dev": "gulp",
+    "lint": "gulp lint",
+    "test": "gulp test"
+  },
+  "dependencies": {
+    "app-root-path": "^2.0.1",
+    "async": "^2.1.2",
+    "boom": "^4.0.0",
+    "glob": "^7.0.0",
+    "joi": "^9.1.1"
+  },
+  "devDependencies": {
+    "eslint": "^3.4.0",
+    "eslint-config-airbnb-base": "^8.0.0",
+    "eslint-plugin-import": "^1.8.0",
+    "gulp": "^3.9.0",
+    "gulp-eslint": "^3.0.1",
+    "gulp-expect-file": "0.0.7",
+    "gulp-print": "^2.0.1",
+    "gulp-tape": "0.0.7",
+    "hapi": "^15.0.3",
+    "tape": "4.6.0",
+    "tape-catch": "^1.0.6"
+  },
+  "author": {
+    "name": "danactive",
+    "url": "http://twitter.com/danactive"
+  },
+  "license": "MIT",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/danactive/history.git"
+  },
+  "engines": {
+    "npm": ">3",
+    "node": ">4"
+  }
+}