-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for Release 0.6.0 #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during the drawing and skip information afterwards
2 minor things and the ShapeBasedPlacer
… (where it really belongs)
If you're passing a Font, you probably know what you're doing, so use the font sized as it is. If you're passing a PFont, default it to the size it's already at. (You're probably shaping a big ol' word for a ShapeBasedImage.) But, if you're passing a PFont, allow a font-size override. This is for the WordCramEngine, which has to size the font for each word, based on the WordSizer.
There are now 4 versions: * The main one, that takes a java Font, size, and angle * One that takes a Font, and uses its default size, and angle of 0 * A PFont version of each of those Also deleted ShapeBasedPlacer's fromTextGlyphs method, since WordShaper should now suffice.
since ImageShaper.shape() is now fast enough. I think that passing a PImage and a Processing color as args will be fine - WordCram is very dependent on Processing, I don't think it'll ever be extracted. Also delete ShapeBasedPlacer.fromImageFile(), which used those methods. ImageShaper has a nice-enough API that we don't need it.
Make WordCrams from shapes, from image masks
PrintStreamObserver as standard console Feedback WordCramEngine can handle one Observer moved word skip reasons to a singleton drawNext returns the processed Word
…tch can be an Observer
Observer implementation, take 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals for this release:
Stuff I decided not to fix for this release: