Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue retrying downloads on retriable statuses #1558

Merged
merged 2 commits into from
Dec 20, 2024

Move `attempt >= attempts_allowed` check

bb05a23
Select commit
Loading
Failed to load commit list.
Merged

Continue retrying downloads on retriable statuses #1558

Move `attempt >= attempts_allowed` check
bb05a23
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 0s

88.53% (+0.14%) compared to 29009f6

View this Pull Request on Codecov

88.53% (+0.14%) compared to 29009f6

Details

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (29009f6) to head (bb05a23).

Files with missing lines Patch % Lines
dandi/download.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
+ Coverage   88.38%   88.53%   +0.14%     
==========================================
  Files          78       78              
  Lines       10736    10735       -1     
==========================================
+ Hits         9489     9504      +15     
+ Misses       1247     1231      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.