Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL for DANDI Docs #1561

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Update URL for DANDI Docs #1561

merged 1 commit into from
Jan 10, 2025

Conversation

kabilar
Copy link
Member

@kabilar kabilar commented Jan 10, 2025

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (669b182) to head (6863c9b).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
- Coverage   88.48%   88.43%   -0.06%     
==========================================
  Files          78       78              
  Lines       10735    10735              
==========================================
- Hits         9499     9493       -6     
- Misses       1236     1242       +6     
Flag Coverage Δ
unittests 88.43% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kabilar kabilar requested a review from jwodder January 10, 2025 19:23
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! We still have a little confusing dandi docs on RTD for the dandi-cli component, but it is what it is. Thank you @kabilar!

@yarikoptic
Copy link
Member

for type checking

and we do have problem installing deps while building docs now which is also unrelated -- let's proceed! Thank you @kabilar

@yarikoptic yarikoptic added the documentation Changes only affect the documentation label Jan 10, 2025
@yarikoptic yarikoptic merged commit ba384c6 into dandi:master Jan 10, 2025
20 of 24 checks passed
@kabilar
Copy link
Member Author

kabilar commented Jan 11, 2025

Makes sense! We still have a little confusing dandi docs on RTD for the dandi-cli component, but it is what it is. Thank you @kabilar!

Hi @yarikoptic, thats a good point. I have filed #1563 to hopefully address this issue.

Copy link

🚀 PR was released in 0.66.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants