Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.10 to build docs #1567

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Use Python 3.10 to build docs #1567

merged 1 commit into from
Jan 23, 2025

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 22, 2025

The docs builds have been failing in CI for a while, always(?) due to pip giving up after excessive backtracking while trying to resolve dependencies. I tested out the following failing command from a recent CI run:

pip install 'anys~=0.2' 'bidsschematools~=0.7.0' click-didyoumean 'click>=7.1' coverage 'dandischema<0.12,>=0.9.0' 'etelemetry>=0.2.2' fasteners 'fscacher>=0.3.0' 'hdmf!=3.14.4,!=3.5.0' humanize 'interleave~=0.1' joblib 'keyring!=23.9.0' keyrings.alt 'nwbinspector!=0.4.32,>=0.4.28' opencv-python packaging platformdirs pycryptodomex 'pydantic~=2.0' 'pynwb!=1.1.0,!=2.3.0,>=1.0.3' 'pyout!=0.6.0,>=0.5' pytest pytest-cov pytest-mock pytest-rerunfailures pytest-timeout python-dateutil 'requests~=2.20' 'responses!=0.24.0,!=0.25.5' 'ruamel.yaml<1,>=0.15' semantic-version tenacity 'urllib3>=2.0.0' vcrpy 'yarl~=1.9' 'zarr_checksum~=0.4.0' 'zarr~=2.10'

... in Docker images of Python 3.9, 3.10, 3.11, & 3.13, and 3.9 (the version our docs CI uses) was the only one that went into excessive backtracking. I suspect that something in our dependency tree dropped support for Python 3.9 in a recent version, but I'm not going to go digging to try to find out what.

Strangely, this does not explain why other CI runs using Python 3.9 aren't failing.

@jwodder jwodder added the documentation Changes only affect the documentation label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (4d0d85b) to head (6e9e6e1).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
+ Coverage   88.34%   88.43%   +0.08%     
==========================================
  Files          78       78              
  Lines       10735    10735              
==========================================
+ Hits         9484     9493       +9     
+ Misses       1251     1242       -9     
Flag Coverage Δ
unittests 88.43% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder marked this pull request as ready for review January 22, 2025 17:55
@jwodder jwodder requested a review from yarikoptic January 22, 2025 17:55
@yarikoptic
Copy link
Member

wonderful, thank you!

@yarikoptic yarikoptic merged commit 5c5c3a3 into master Jan 23, 2025
26 checks passed
@yarikoptic yarikoptic deleted the up-py-docs branch January 23, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants