-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug-fixes and improvements #56
Open
eeshlomi
wants to merge
14
commits into
dangmocrang:master
Choose a base branch
from
eeshlomi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For iDracs with more then two fans, perf_data was included in the value itself from the third fan and on. That was generating an extra value for the same fan when its RPM changed, causing too many values (Fan IDs) and untraceable graph. Now Fans output is consolidated to a single line after the "|" (pipe) separator so that Opsview keeps collecting the output as expected.
Added spaces between values ("data series")
eeshlomi
changed the title
Compensate an Opsview bug in fan perfdata
Bug-fixes and improvements
Apr 14, 2019
too much commits.. we need a better new request for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For iDracs with more than two fans, perf_data was included in the value itself from the third fan and up. That was generating an extra value for the same fan when its RPM changed, causing too many values (Fan IDs) and untraceable graph.
Now Fans output is consolidated to a single line after the "|" (pipe) separator so that Opsview keeps collecting the output as expected.