Update for changing independently the "width", "height" parameters and added the possibility for changing also the "margin". #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd added the posibility for changing also the "margin".
| 'height': options.height | ||
| }); | ||
| } | ||
| if (options.margin) { |
There was a problem hiding this comment.
I like the optional width & height, but I intentionally added only the ability to set those width & height programmatically because the tags inside the input are affected by those dimensions. The plugin itself won't benefit from being able to programmatically adjust margin, but margin can just as easily be set with CSS: .tag-this { margin: 20px; }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I created an issue because I tried to just use the "width" parameter to change the component size and it didn't work, then I tried also with the "height" and it's work.
I search a bit on your code and I think I found the part related with this, I just adapted to support independently the "width" or the "height" and added also the "margin".
I tested these changes and work correctly, but I don't know if there is some other code related with this that should be changed, at least I didn't noted from this first analysis.