error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> crates/chain/src/spk_client.rs:260:64 | 260 | .insert(keychain, Box::new(keychain_spks.chain(spks.into_iter()))), | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `spks` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/iter/traits/iterator.rs:483:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: unnecessary use of `get(&0).is_none()` --> crates/chain/src/local_chain.rs:362:19 | 362 | if blocks.get(&0).is_none() { | -------^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!blocks.contains_key(&0)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check

error: assigning the result of `Clone::clone()` may be inefficient --> crates/chain/src/local_chain.rs:268:9 | 268 | self.current = current.prev.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.current.clone_from(&current.prev)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `-D clippy::assigning-clones` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`

error: unnecessary use of `get(index).is_none()` --> crates/chain/src/spk_txout_index.rs:232:21 | 232 | self.unused.get(index).is_none() | ------------^^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!self.unused.contains(index)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `-D clippy::unnecessary-get-then-check` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_get_then_check)]`

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, Swatinem/[email protected], actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/