Migrating from winapi to windows-sys #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthib
force-pushed
the
migration-winapi-windows
branch
from
39d9da2
to
ebaab7b
Compare
nickelc
reviewed
Apr 3, 2023
Cargo.toml
Outdated
| "winerror", | ||
| "winnt", | ||
| ]} | ||
| windows-sys = { version = "0.45", features = [ |
There was a problem hiding this comment.
windows-sys 0.48 was released some days ago.
There was a problem hiding this comment.
I updated the MR. However the maintainer does not seems to be active anymore, so I doubt this will get merged
vthib
force-pushed
the
migration-winapi-windows
branch
from
ebaab7b
to
0953044
Compare
|
Would be cool to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows-sys(andwindows) are crates for bindings on Windows API officially supported by Microsoft. They are replacingwinapiin many crates, and it would be nice to migrate this great project too :)The differences in the API call are minimal. The other differences are mainly in the type used for constants, which can vary between i32 and u32, and is often not the same as the winapi one.