Made retrieval of dependency from location more defensive (preventing…

[msaladin]

Hi Daniel,

in the newest spring BOM there is at least one dependency under dependencyManagement that leads
to a NPE:

[ERROR] Failed to execute goal com.github.danielflower.mavenplugins:multi-module-maven-release-plugin:3.6-SNAPSHOT:release (default-cli) on project example-app-parent: Execution default-cli of goal com.github.danielflower.mavenplugins:multi-module-maven-release-plugin:3.6-SNAPSHOT:release failed: Cannot invoke "org.apache.maven.model.InputLocation.getSource()" because the return value of "org.apache.maven.model.Dependency.getLocation(Object)" is null -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.danielflower.mavenplugins:multi-module-maven-release-plugin:3.6-SNAPSHOT:release (default-cli) on project example-app-parent: Execution default-cli of goal com.github.danielflower.mavenplugins:multi-module-maven-release-plugin:3.6-SNAPSHOT:release failed: Cannot invoke "org.apache.maven.model.InputLocation.getSource()" because the return value of "org.apache.maven.model.Dependency.getLocation(Object)" is null
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
...
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal com.github.danielflower.mavenplugins:multi-module-maven-release-plugin:3.6-SNAPSHOT:release failed: Cannot invoke "org.apache.maven.model.InputLocation.getSource()" because the return value of "org.apache.maven.model.Dependency.getLocation(Object)" is null
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
...
Caused by: java.lang.NullPointerException: Cannot invoke "org.apache.maven.model.InputLocation.getSource()" because the return value of "org.apache.maven.model.Dependency.getLocation(Object)" is null
    at com.github.danielflower.mavenplugins.release.Reactor.hasSameMavenGAByDependencyLocation (Reactor.java:145)
    at com.github.danielflower.mavenplugins.release.Reactor.fromProjects (Reactor.java:72)
    at com.github.danielflower.mavenplugins.release.ReleaseMojo.execute (ReleaseMojo.java:162)

The dependency in question is:

    <dependencyManagement>
      <dependencies>
        <dependency>
          <groupId>org.apache.maven.plugin-tools</groupId>
          <artifactId>maven-plugin-annotations</artifactId>
          <version>3.11.0</version>
        </dependency>
      </dependencies>
    </dependencyManagement>

The problem is the following code:

Reactor.java, line 144:

String[] modelId = dependency.getLocation("").getSource().getModelId().split(":");
return modelId[0].equals(module.getGroupId()) && modelId[1].equals(module.getArtifactId());

I would like to make this more defensive, what do you think about this PR?

Currently, I don't see any workaround this. So if you would be willing to merge the PR, do you plan to make a new release of the plugin soon?

Thanks & Cheers
Michael

[dagerber]

This is a problem for me as well. Could you merge and make a release (also with the Java 11 change)?
Would be much appreciated!

[danielflower]

This looks fine - but need to wait for the master branch to be working again. (I'm not going to change to Java 11 at this time)

[danielflower]

This has been released in 3.7.8. Thanks!