-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/allow dependency snapshots #39
base: master
Are you sure you want to change the base?
Feature/allow dependency snapshots #39
Conversation
Good to hear you've found the plugin useful. Just so I can fully understand this: is the use case where projects A and B are in different Git repos? If so, could you make the end to end test more complete by releasing the depended-on project multiple times and confirming the latest version gets picked up? I've never seen things like the ArtifactFactory/MetaDatasource classes - are those just checking in the local repo for versions? Or the remote one too? Also note that the Travis build has failed with the following message:
See https://travis-ci.org/danielflower/multi-module-maven-release-plugin/builds/160907059 |
@danielflower Would love to see this PR get merged. We need support for snapshot repository upload. |
@rverma-nikiai have you seen that @danielflower likes to get an extended end2end test to accept the contribution. I am not actively using the plugin any longer so I have no motivation to provide the extension currently. Feel free to take over the current state and help to complete it as required. |
7f4f7af
to
e1cff97
Compare
I have rebased my changes to the latest 3.0-SNAPSHOT on origin/master (and created a 3.1-SNAPSHOT out of it as suggested by the CONTRIBUTING guide). Now it is up to you, @rverma-nikiai and @danielflower to finish and merge my work. |
This is my solution to #38