Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/allow dependency snapshots #39

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ascheman
Copy link

This is my solution to #38

@danielflower
Copy link
Owner

Good to hear you've found the plugin useful.

Just so I can fully understand this: is the use case where projects A and B are in different Git repos? If so, could you make the end to end test more complete by releasing the depended-on project multiple times and confirming the latest version gets picked up?

I've never seen things like the ArtifactFactory/MetaDatasource classes - are those just checking in the local repo for versions? Or the remote one too?

Also note that the Travis build has failed with the following message:

[ERROR] /home/travis/build/danielflower/multi-module-maven-release-plugin/src/main/java/com/github/danielflower/mavenplugins/release/PomUpdater.java:[167,21] cannot find symbol
  symbol:   method sort(<anonymous java.util.Comparator<org.apache.maven.artifact.versioning.ArtifactVersion>>)
  location: variable versions of type java.util.List<org.apache.maven.artifact.versioning.ArtifactVersion>

See https://travis-ci.org/danielflower/multi-module-maven-release-plugin/builds/160907059

@rverma-nikiai
Copy link

@danielflower Would love to see this PR get merged. We need support for snapshot repository upload.
Also the default upload logic need to get relaxed for the snapshot. Would be nice if we can run snapshot target without commit.

@ascheman
Copy link
Author

@rverma-nikiai have you seen that @danielflower likes to get an extended end2end test to accept the contribution. I am not actively using the plugin any longer so I have no motivation to provide the extension currently. Feel free to take over the current state and help to complete it as required.

@ascheman ascheman force-pushed the feature/allow-dependency-snapshots branch from 7f4f7af to e1cff97 Compare March 29, 2019 21:29
@ascheman
Copy link
Author

I have rebased my changes to the latest 3.0-SNAPSHOT on origin/master (and created a 3.1-SNAPSHOT out of it as suggested by the CONTRIBUTING guide). Now it is up to you, @rverma-nikiai and @danielflower to finish and merge my work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants