Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kombu.transport.pyamqp import to pyinstaller #271

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

chripf
Copy link

@chripf chripf commented Oct 19, 2023

This is required for work with rabbitmq.
Should fix #119 - regarding the last comments.

@CFarcy
Copy link
Contributor

CFarcy commented Jan 24, 2024

Any news on this PR being merged ?

@Legrems
Copy link

Legrems commented Feb 27, 2024

Dump? Still got the issue when using the executable alone :)

@danihodovic
Copy link
Owner

@CFarcy and @Legrems can you check out this branch and confirm that it works? Once you do I'll merge the PR.

Sorry about the delay, I was traveling through the jungle

Dockerfile.pyinstaller Outdated Show resolved Hide resolved
@CFarcy
Copy link
Contributor

CFarcy commented Mar 1, 2024

Thanks for your reply @danihodovic , I hope you had a good time in the jungle :)

There is a typo in the Dockerfile.pyinstaller (missing space before \). I proposed a change for it.

Once the typo fixed, it seems to works (at least it run with no error).

Here is what I did to test it:

docker build . -t celery-exporter-builder -f Dockerfile.pyinstaller --build-arg PYTHON_VERSION=$(cat .python-version)
container=$(docker run --rm -d celery-exporter-builder sleep 5) && docker cp $container:/app/dist/celery-exporter ./celery-exporter
./celery-exporter --broker-url=amqp://localhost:5672

Then the metrics are available on localhost:9808
image

Co-authored-by: Cédric Farcy <[email protected]>
@danihodovic danihodovic merged commit 1496ac0 into danihodovic:master Mar 1, 2024
5 of 6 checks passed
@danihodovic
Copy link
Owner

Released as v0.10.4 here https://github.com/danihodovic/celery-exporter/releases/tag/v0.10.4.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault using the binary
4 participants