Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use event timestamp based on utcoffset #314

Merged

Conversation

reshab48
Copy link
Contributor

@reshab48 reshab48 commented Jul 17, 2024

celery-exporter has this feature to purge ofline worker metrics which default to 10 minutes. So any worker that is offline for more than 10 minutes, the metrics of which will be purged
Now if celery workers is configured to use PST timezone (which is 7 hours behind UTC) or any other timezone that is not UTC, in such cases celery-exporter (running in UTC tz) considered live workers also to be offline because of this offset and this causes a continuous loop of live worker metrics to be purged and so we get inconsistent metrics.

Temp solution is to set CE_WORKER_TIMEOUT and CE_PURGE_OFFLINE_WORKER_METRICS to 7hrs + 10mins ahead

@danihodovic
Copy link
Owner

@adinhodovic can you chime in

Copy link
Collaborator

@adinhodovic adinhodovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Thanks!

@adinhodovic adinhodovic merged commit 37c8004 into danihodovic:master Jul 23, 2024
6 checks passed
@danihodovic
Copy link
Owner

Released as docker.io/danihodovic/celery-exporter:0.10.9

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants