Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some options from COMMENTS_XTD_APP_MODEL_OPTIONS are not honored #423

Closed
gamboz opened this issue Mar 25, 2024 · 1 comment
Closed

Some options from COMMENTS_XTD_APP_MODEL_OPTIONS are not honored #423

gamboz opened this issue Mar 25, 2024 · 1 comment

Comments

@gamboz
Copy link

gamboz commented Mar 25, 2024

If I add to my django settings the variable COMMENTS_XTD_APP_MODEL_OPTIONS as follows,

COMMENTS_XTD_APP_MODEL_OPTIONS = {
    "myapp.somemodel": {
        "allow_feedback": True,
        ...

the options "allow_feedback" and others are ignored in when building the "props" by django_comments_xtd.api.frontend.CommentBoxDriver (e.g. here).

If I understand correctly this documentation, the lines for the four options defined by default in utils.get_app_model_options (here) should read something like "allow_flagging": options['allow_flagging'],

This issue should be solved by #422

@gamboz
Copy link
Author

gamboz commented Mar 25, 2024

This has already been addressed in https://github.com/danirus/django-comments-xtd/tree/rel-3.0.0

And development seems to be here: https://pypi.org/project/django-comments-ink/

I'm closing this issue 🙂

@gamboz gamboz closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant