COMMENTS_XTD_APP_MODEL_OPTIONS used on get_commentbox_props #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this way the settings parameter can overwrite the values for the specific model
gamboz
reviewed
Mar 25, 2024
| @@ -143,6 +143,10 @@ def get_props(cls, obj, user, request=None): | |||
| d['like_url'] = reverse("comments-xtd-like", args=(0,)) | |||
| d['dislike_url'] = reverse("comments-xtd-dislike", args=(0,)) | |||
|
|
|||
| defaults_per_model = settings.COMMENTS_XTD_APP_MODEL_OPTIONS[str(ctype).replace(' | ', '.')] | |||
There was a problem hiding this comment.
I hit the same problem (see #423) and was looking at your MR that solves it 🙂
I think that on line 92 above, the options for the app model might have already been collected (options = get_app_model_options(content_type=ctype_key) so down here it could be sufficient to d.update(options).
See also l.100 "who_can_post": options['who_can_post'],.
However, I'm not sure if, at the moment, the function get_app_model_options() does the replace(' | ', '.') trick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this way the settings parameter can overwrite the values for the specific model