fix: docker image publish to dockerhub

danishjoseph · Jul 16, 2024 · 6a9b17a · 6a9b17a
1 parent ca5c407
commit 6a9b17a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -52,7 +52,7 @@ jobs:
 
       - name: Get version number
         id: version
-        run: echo "VERSION=$(cat ./package.json | jq -r '.version')" >> $GITHUB_ENV
+        run: echo "version=$(cat ./package.json | jq -r '.version')" >> $GITHUB_OUTPUT
 
       - name: Build Docker image
         run: |
@@ -68,7 +68,7 @@ jobs:
     name: Push Docker image to DockerHub
     needs: build
     runs-on: ubuntu-latest
-    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
+    # if: github.event_name == 'push' && github.ref == 'refs/heads/main'
     steps:
       - name: Download Docker image
         uses: actions/download-artifact@v3
@@ -85,4 +85,4 @@ jobs:
           password: ${{ secrets.DOCKER_HUB_TOKEN }}
 
       - name: Push Docker image
-        run: docker push ${{ secrets.DOCKER_HUB_USERNAME }}/stockdog:v-${{ env.VERSION  }}
+        run: docker push ${{ secrets.DOCKER_HUB_USERNAME }}/stockdog:v-${{ needs.build.outputs.version }}