Display user fullname and replace capability check in dialogue creation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumaiyamannan
force-pushed
the
MOODLE_401_STABLE-fullname_capability_check
branch
2 times, most recently
from
8b3bac1 to
a8acfc4
Compare
…lity. Replace core capability check with mod_dialogue 'open' capability in webservice call
sumaiyamannan
force-pushed
the
MOODLE_401_STABLE-fullname_capability_check
branch
from
a8acfc4 to
2681679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This will fix the below issues:
Remove the requirement for students to have the moodle/course:viewparticipants' capability when creating a dialogue. Instead use the mod/dialogue:open capability check.
This is a data protection issue for some as it means that this setting hinders the ability to disable Student access to the course participants page.
Display participants fullname depending on the receiver/viewed capability
If the logged in user has 'viewfullnames' capabilities then they will see the user fullname as $CFG->alternativefullnameformat otherwise as $CFG->fullnamedisplay
Include students course name in the email notifications sent
Regards,
Sumaiya