Fixes Column 'dmsf_mail_notification' cannot be null #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The partial app/views/dmsf_state/_user_pref.html.erb uses a condition to include the email_notify setting only if the corresponding notified_event is enabled. The database field email_notify, however, does not accept a null value. But this is what occurs when the notified event is disabled. This patch changes the DmsfStateController to assign params[:email_notify] only if the notified_event for dmsf_legacy_notifications is enabled.
|
Please fix the tests. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial app/views/dmsf_state/_user_pref.html.erb uses a condition to include the email_notify setting only if the corresponding notified_event is enabled. The database field email_notify, however, does not accept a null value. But this is what occurs when the notified event is disabled.
This patch changes the DmsfStateController to assign params[:email_notify] only if the notified_event for dmsf_legacy_notifications is enabled.