Refactorize the code with new OCaml tools #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dannywillems Hi there! Do you want to merge maybe? It would help us with extending the module. |
Hi @jrochel. I was waiting for an answer from your side here. If you answer negatively, I can build on my side the example app https://github.com/dannywillems/ocaml-cordova-plugin-inappbrowser-example. It is fine to do it on my side, but as it has been a long time I didn't work on mobile apps, I will need to setup the environment on my machine. Let me know. |
|
@dannywillems This PR does not seem to have any backwards compatibility issues according to our tests. |
|
Perfect, thanks for testing! Merging then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the module name.