Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command to easy replace cover #132

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

cableman
Copy link
Contributor

@cableman cableman commented Oct 5, 2022

Link to ticket

https://jira.itkdev.dk/browse/SUPP0RT-690

Description

Command to help fast and easy replacement of a cover image.

Screenshot of the result

N/A

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

N/A

@cableman cableman requested a review from turegjorup October 5, 2022 10:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #132 (5a92037) into develop (9dd67ae) will increase coverage by 0.59%.
The diff coverage is 8.13%.

@@             Coverage Diff              @@
##             develop    #132      +/-   ##
============================================
+ Coverage       9.17%   9.77%   +0.59%     
- Complexity       958    1126     +168     
============================================
  Files             99      94       -5     
  Lines           3117    3480     +363     
============================================
+ Hits             286     340      +54     
- Misses          2831    3140     +309     
Flag Coverage Δ
7.4 ?
8.1 9.77% <8.13%> (?)
unittests 9.77% <8.13%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Command/CoverStore/CoverStoreMoveCommand.php 0.00% <0.00%> (ø)
src/Command/CoverStore/CoverStoreRemoveCommand.php 0.00% <0.00%> (ø)
src/Command/CoverStore/CoverStoreSearchCommand.php 0.00% <0.00%> (ø)
src/Command/CoverStore/CoverStoreUploadCommand.php 0.00% <0.00%> (ø)
...mand/CoverStore/CoverStoreValidateImageCommand.php 0.00% <0.00%> (ø)
src/Command/HasCoverCommand.php 0.00% <0.00%> (ø)
src/Command/Image/MissingImagesCommand.php 0.00% <0.00%> (ø)
...c/Command/OpenPlatform/OpenPlatformAuthCommand.php 0.00% <0.00%> (ø)
...Command/OpenPlatform/OpenPlatformSearchCommand.php 0.00% <0.00%> (ø)
src/Command/QueueInsertCommand.php 0.00% <0.00%> (ø)
... and 128 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cableman cableman force-pushed the feature/replace-cover branch from 5a92037 to d903988 Compare October 5, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants