Add support for health checks #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the https://github.com/ans-group/laravel-health-check package to add support for health checks. This is useful when adding external monitoring of the application. The package used is somewhat popular, has explicit support for Lumen and the somewhat old PHP version that we use. The default configuration checks that we have acces to the database, a working logging system and whatever environment variables that we need. Tests show that it returns uncacheable response headers by default. That should be sufficient for an initial version of us.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage 97.61% 97.61%
Complexity 42 42
=========================================
Files 6 6
Lines 126 126
=========================================
Hits 123 123
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the https://github.com/ans-group/laravel-health-check package to add support for health checks. This is useful when adding external monitoring of the application.
The package used is somewhat popular, has explicit support for Lumen and the somewhat old PHP version that we use.
The default configuration checks that we have acces to the database, a working logging system and whatever environment variables that we need. Tests show that it returns uncacheable response headers by default.
That should be sufficient for an initial version of us.