DDFLSBP-651 - Implement cookie blocking placeholder #1220
Conversation
…custom cookie functionality, that are not configurable in either the cookieinformation module or cookieinformation dashboard. For now I have added a single preprocessing function, that modifies all video media iFrames, adding new attributes that cookieinformation is used for handling cookies.
…ceholder to all video media elements.
…nt-cookie-blocking-placeholder
…ia fields than video
There was a problem hiding this comment.
Hvis jeg afviser alle cookies ser jeg dette på en side hvor der er indsat et Vimeo klip:
Det er muligvis mit lokalmiljø som driller med stylingen, men under alle omstændigheder kunne det måske være en forbedring at lave <div class="video-embed__wrapper"> elementet lidt lavere, når cookie-placeholder vises, således at der ikke er så meget "tom" plads?
web/themes/custom/novel/templates/fields/field--media--video.html.twig
Outdated
Show resolved
Hide resolved
…slatable aria-label text
Good suggestion. I have already used some time on this PR, so I think I will skip this for now. Maybe this is also something that we need to clear up with the client beforehand. 😄 |
…m by adding a pagefold div
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-651
Description
This PR introduces the following:
A new custom module (dpl_cookies), used for handling all custom cookie functionality, that is not handled in either the cookieinformation module or cookieinformation dashboard. For now this includes a preprocess hook that adds 3 new data attributes to all video media elements. These attributes are need by the cookieinformation script when handling user cookie consent.
A new template specifically targeting field--media--video. In this template we have added our custom cookie placeholder, which gets shown to user who have not yet consented to using cookies, in place of the original content.
Screenshot of the result
Screenrecording showing the result:
Screen.Recording.2024-06-06.at.14.13.01.mov
Additional comments or questions
This PR has a sister PR in the dpl-design-system: danskernesdigitalebibliotek/dpl-design-system#650