Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New FBI API changes #1501

Merged
merged 11 commits into from
Oct 22, 2024
Merged

New FBI API changes #1501

merged 11 commits into from
Oct 22, 2024

Conversation

dpl-platform-bot
Copy link
Collaborator

@dpl-platform-bot dpl-platform-bot commented Aug 21, 2024 •
edited by spaceo
Loading

Link to issue

https://reload.atlassian.net/browse/DDFBRA-38

Description

FBI API has changed. Initially it was communicated that it was only about naming conventions but a lot of structural changes has been changed as well.
Both matters is being handled in this PR.

Changes in this branch

  • Using new refactored version of dpl-react (goes without saying)
  • Changes to wiremock fixtures because of new data structures
  • Changed the FBI API domain to the prefixed temp.one

If you want to test it manually it can be done here:
https://varnish.pr-1501.dpl-cms.dplplat01.dpl.reload.dk

@github-actions github-actions bot temporarily deployed to pr-1501 August 21, 2024 13:07 Destroyed
@spaceo spaceo closed this Aug 28, 2024
@spaceo spaceo reopened this Sep 24, 2024
@github-actions github-actions bot temporarily deployed to pr-1501 September 24, 2024 15:15 Destroyed
@spaceo spaceo force-pushed the DDFLSBP-790-peg-pa-fb-is-aendrede-api branch from 63d474d to c2ba451 Compare September 24, 2024 16:03
@github-actions github-actions bot temporarily deployed to pr-1501 September 24, 2024 16:04 Destroyed
@spaceo spaceo force-pushed the DDFLSBP-790-peg-pa-fb-is-aendrede-api branch from c2ba451 to 28045d5 Compare September 24, 2024 16:10
@github-actions github-actions bot temporarily deployed to pr-1501 September 24, 2024 16:10 Destroyed
@github-actions github-actions bot temporarily deployed to pr-1501 September 24, 2024 19:37 Destroyed
@spaceo spaceo force-pushed the DDFLSBP-790-peg-pa-fb-is-aendrede-api branch from 2f77a79 to 8a1278f Compare September 24, 2024 19:43
@github-actions github-actions bot temporarily deployed to pr-1501 September 24, 2024 19:44 Destroyed
@spaceo
Use temp FBI API
6d33e06 
until it is possible to swap back to non-temp version
@github-actions github-actions bot temporarily deployed to pr-1501 September 25, 2024 07:40 Destroyed
@spaceo spaceo changed the title PR for danskernesdigitalebibliotek/dpl-react:DDFLSBP-790-peg-pa-fb-is-aendrede-api New FBI API changes Sep 25, 2024
@github-actions github-actions bot temporarily deployed to pr-1501 September 26, 2024 13:36 Destroyed
Adamik10
Adamik10 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Adamik10 Adamik10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from here :)
Good luck to whoever needs to test this.

@Adamik10
Copy link
Contributor

Plot twist - it was me

@Adamik10 Adamik10 merged commit f89ba79 into develop Oct 22, 2024
19 checks passed
@Adamik10 Adamik10 deleted the DDFLSBP-790-peg-pa-fb-is-aendrede-api branch October 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adamik10 Adamik10 Adamik10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dpl-platform-bot @Adamik10 @kasperg @spaceo @Dresse @ThomasGross