-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2024.43.0 #1671
Merged
Release 2024.43.0 #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should support responses for all types of patrons.
This will allow editors test their campaigns in the same browser as they are creating the campaign in. Without this they would have to log out and test the campaign in an anonymous browser. The situation is caused by the fact that the request contains a cookie which is an authentication method, but the campaign endpoint is not configured to support it. To address this we add support for cookie-based authentication. For this to work out of the box we need to disaable the X-CSRF requirement which we have also done elsewhere. For this endpoint it should not make a difference as it is usable for all types of users and thus does not need extra protecton. Update the specification and generated packages accordingly.
Allow the `administrator`, `local administrator`, and `editor` to delete an opening hour category. Unclear why this setting was previously enabled for `user.role.editor.yml`.
Now, when a user deletes a category, a message will display indicating the number of associated opening hours. To facilitate this, the `$categoryId` parameter was added to the `loadMultiple` method in the `OpeningHoursRepository`. At present, no specific action occurs on term deletion. Handling this will be part of the next commit.
This architecture caused several issues, but we eventually discovered that the problem was due to the order of submit callbacks. We resolved it by using `array_unshift($form['actions']['submit']['#submit'], 'dpl_opening_hours_term_delete_submit');` to adjust the order. However, we are not fully satisfied with this approach, and in the next commit, I have implemented `dpl_opening_hours_taxonomy_term_predelete` to handle the deletion process more cleanly.
Implemented `hook_taxonomy_term_predelete()` to automatically delete associated opening hours when a category term is deleted. This ensures that all related opening hours are cleaned up upon term deletion.
until it is possible to swap back to non-temp version
Due to Drupal/OOP best standards.
Remove unnecessary variable used only once.
The repository allows a null repetition ID, making the check unnecessary.
We can use `.lagoon.yml` to set up a GH deployment, that we can use to listen for in GH actions. This is an alternative to us spending a lot of GH minutes just waiting for the site to become available. By using bash traps, we can also send back error codes when `drush deploy` (or other stuff) goes wrong. This means we have to remove the `set -e`, but we get around that by calling exit in the catcher. Ontop of that, also setting up `concurrency` rules to `ci-tests`, so if a second push is made, we cancel the old and unrelated workflow. With this set up, a new GH Action can be created, if you need a link to the environment: ``` on: deployment_status jobs: tests: if: github.event.deployment_status.state == 'success' runs-on: ubuntu-latest steps: - run: echo "$URL" env: URL: ${{ github.event.deployment_status.target_url }} ```
See more info in the upstream merge request: https://git.drupalcode.org/project/recurring_events/-/merge_requests/112
- drupal/next - drupal/graphql - drupal/graphql_compose
the graphql compose schema configuration and adding a new user role which we intend to use for authenticating when calling the graphql endpoint. This is not set in stone and can be changed at a later point.
on development environments.
This is only intended to be used in the development phase.
Only for development usage.
…ql-modules-i-dpl-cms
and running a reset on the environment.
Bumps the minor-js-dependencies group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 8.8.1 to 8.9.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.9.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 8.8.1 to 8.9.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.9.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-js-dependencies - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-js-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
interfering with the REST API requests for opening_hours. I tried to configure it so the oauth2 authentication method would not apply for other endpoints other than graphql, but was unsuccessful. Decided to skip this for now and return and look on how to enalbe oauth authentication again on a later point.
Added graphql permission to graphql_consumer role instead.
…psaetning-af-next-js-og-graph-ql-modules-i-dpl-cms DDFBRA-76 - Opsætning af next.js og graphQl modules i dpl-cms
…npm_and_yarn/minor-js-dependencies-54d3ffe6ab Bump the minor-js-dependencies group with 2 updates
Bumps the minor-js-dependencies group with 3 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [cypress-if](https://github.com/bahmutov/cypress-if). Updates `@typescript-eslint/eslint-plugin` from 8.9.0 to 8.11.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.11.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 8.9.0 to 8.11.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.11.0/packages/parser) Updates `cypress-if` from 1.12.6 to 1.13.0 - [Release notes](https://github.com/bahmutov/cypress-if/releases) - [Commits](bahmutov/cypress-if@v1.12.6...v1.13.0) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-js-dependencies - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-js-dependencies - dependency-name: cypress-if dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-js-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
…npm_and_yarn/minor-js-dependencies-bb93a10eef Bump the minor-js-dependencies group with 3 updates
…-peg-pa-fb-is-aendrede-api New FBI API changes
…itle Event API: Respect inheritance of eventinstance title.
…4.43.0 Use release 2024.43.0 of design system and React components
…gns-for-editors-DDFNEXT-368 Show campaigns for editors
…event-start-any Patching reccurring events, allowing any start/end time. DDFHER-45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.