DDFBRA-96 extend GraphQL schema with go config #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core.extensions config as well as through the dpl_update install hooks.
the 'admin/config/services'. Added 4 fields to the configuration: - UniLogin API endpoint. - UniLogin API wellknown endpoint. - UniLogin client ID. - UniLogin client secret.
…sions. Added a new GraphQLCompose SchemaType called DplConfiguration which is gonna be used for serving all relevant dpl-cms configuration to dpl-go. The SchemaType is pretty stripped down, but is gonna be extended through our other custom modules.
We now extend on the DplConfiguration SchemaType from dpl_graphql.
Dresse
force-pushed
the
DDFBRA-96-extend-graphql-schema-with-go-config
branch
2 times, most recently
from
a5db505 to
ebc36ac
Compare
Dresse
force-pushed
the
DDFBRA-96-extend-graphql-schema-with-go-config
branch
from
ebc36ac to
56f7d60
Compare
… unusable field, we decided to move all of the logic inside the dpl_graphql module again. This PR removes the GraphQL and GraphQLCompose plugins in dpl_unilogin module, and instead moves it into the dpl_graphql module. I also removed a README.md file explaining how to extend the DplConfiguration SchemaType. I have saved my work in another branch locally, so if we need to go back and re-visit the decision, the work is not totally lost.
Dresse
force-pushed
the
DDFBRA-96-extend-graphql-schema-with-go-config
branch
from
13aa5bc to
f06827f
Compare
…r this is that we can't be sure that the values has been set correctly, when they are set to null, the frontend can handle the logic. Changed the unilogin resolver to check if unilogin values has been set. If not we now return NULL. Instead we now set the default values of the non-sensitive endpoints in settings.php but only for non-production environments. Also added dpl_unilogin.settings to config ignore, as we do not want to override these variables.
spaceo
approved these changes
Oct 31, 2024
…s" post-rollout tasks. Assigned the new user the graphql_consumer role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-96
Description
This PR adds 2 new custom modules: