DDFBRA-183 - Anonymous and logged in user can try ebook + audiobook #1779
+106
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
da39c1e to
cd45554
Compare
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
10b79f5 to
6a0834f
Compare
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
8f4ebba to
f1da091
Compare
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
f1da091 to
0e6b2d6
Compare
kasperbirch1
changed the title
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
0e6b2d6 to
d6c7f10
Compare
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
7c4f93e to
314697e
Compare
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
314697e to
5c811e1
Compare
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
5c811e1 to
273fe23
Compare
kasperg
requested changes
Dec 5, 2024
web/modules/custom/dpl_react_apps/src/Controller/DplReactAppsController.php
Outdated
Show resolved
Hide resolved
web/modules/custom/dpl_react_apps/src/Controller/DplReactAppsController.php
Outdated
Show resolved
Hide resolved
web/modules/custom/dpl_react_apps/src/Controller/DplReactAppsController.php
Outdated
Show resolved
Hide resolved
web/modules/custom/dpl_react_apps/src/Plugin/Block/ReaderAppBlock.php
Outdated
Show resolved
Hide resolved
web/themes/custom/novel/templates/layout/page--reader.html.twig
Outdated
Show resolved
Hide resolved
web/modules/custom/dpl_react_apps/src/Controller/DplReactAppsController.php
Outdated
Show resolved
Hide resolved
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
23a70d9 to
c57ef2d
Compare
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
c57ef2d to
6ea1d6c
Compare
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
6ea1d6c to
8644ba4
Compare
The `/reader` route now passes either the `identifier` or `orderId` parameters to the `Reader` React app. This was implemented to ensure the proper loading of external scripts that require a full page reload.
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
This caused issues when passing the URL parameter from Drupal into the `Reader` app. Additionally, I have set the default value of `orderid` to an empty string, similar to how `identifier` is handled.
The `reader-modal-description-text` is no longer utilized.
- Removed unnecessary comments
- Removed redundant div wrapper.
- Removed the `{{ drupal_block('system_messages_block') }}`. as it not needed here
Remove the unnecessary inclusion of the `Reader` react app within a Block. Instead, render the `Reader` app at the `/reader` route, with the identifier or order ID as optional parameters. The app will be rendered using the `page--reader.html.twig` template, which does not include a header or footer.
Using `BadRequestHttpException` results in an HTTP 400 error response, which correctly signals a client error, making the API behavior more RESTful and easier to debug for clients.
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
8644ba4 to
8b80f8f
Compare
kasperbirch1
deleted the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-183
https://reload.atlassian.net/browse/DDFBRA-184
Description
This pull request adds translations for Reader link as part of the updates introduced in dpl-react/pull/1555.
During the work on dpl-react/pull/1555, we discovered that rendering Reader within a modal, as originally planned, was not feasible. As a result, Reader has been refactored into a standalone application instead of a component within the material app.
In the material app, navigating to “/reader” now triggers a page transition, with either
identifierororderIdpassed along as parameters.Test
https://varnish.pr-1779.dpl-cms.dplplat01.dpl.reload.dk/work/work-of:870970-basis:136089471?type=tegneserie+%28online%29
Additionally, this implementation facilitates testing of the updated functionality.