Release 2024.49.0 #1824
Merged
Release 2024.49.0 #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach is somewhat frail in regards to ensuring correct and consistent formatting. In practice it also has challenges given the fact that it requires us to ensure that our values are properly encoded. We have currently done this for the description but in practice we also need to do this for all other values. To avoid this we update the implementation to use core PHP XML Writer instead. It has a number of advantages over alternate solutions: - SimpleXML does not allow the same amount of control of the output. Example; I could not get it to add an explicit encoding attribute on the root XML element. - Third party solutions add to our dependency tree. We do not want to do this to maintain a legacy solution. The new implementation has been checked by matching it with the existing one using semantic diff'ing with difftastic. It matches 1-to-1 except for the following exception: When data is missing e.g. branch or media then the related elements are omitted instead of returning empty elements. By doing this we can drop the encoding of the description we already added.
It should be medium - not contentmedium.
Sometimes we want to display ranges of prices in situations where it is not appropriate to apply the additional formatting that we normally do (current prefix, "free" instead of 0 etc.) One example for this is the RSS feed for the Redia app. This adds support for this supported by a unit test.
Prices in the original feed are (mostly) displayed as raw integers in the format "[price]" or "[low price] - [high price]". If the event is free then there is no price element for it in the feed. Add support for similar output in the our new implementation of the feed by using the raw price range formatting.
This reverts commit f7f903a.
…ER-132 As we use inheritance, we want an updated series to also reflect in the updatedAt API property. We could implement this, by programmatically saving all instances when the series is saved, but this may have unforseen consequences, as it is running against the Drupal system. Instead, we'll look up the instance and series changed dates, and take which ever is newer.
See https://github.com/reload/https-proxy/tree/main#:~:text=cert%3Arw%27-,Tip,-Install%20mkcert%20on for one-time setup and https://github.com/reload/drupal-apache-fpm?tab=readme-ov-file#dory for one-time Dory setup.
NOTE: We need to find the proper settings in PR/prod as well
Add a dev https site
It is error prone and confusing to use multiple domain names. Plus reload/https-proxy image in docker-compose.dev.yml is set to use that domain for https
…-til-at-kore-med-https-og-opsaet-cors-configuration
…saet-dpl-cms-dapple-cms-docker-til-at-kore-med-https-og-opsaet-cors-configuration No CORS + Https
Bumps drupal/admin_toolbar from 3.5.0 to 3.5.1. --- updated-dependencies: - dependency-name: drupal/admin_toolbar dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps drupal/antibot from 2.0.3 to 2.0.4. --- updated-dependencies: - dependency-name: drupal/antibot dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
It has previous been uninstalled and can now be removed from the project codebase.
…composer/drupal/admin_toolbar-3.5.1 Bump drupal/admin_toolbar from 3.5.0 to 3.5.1
…composer/drupal/antibot-2.0.4 Bump drupal/antibot from 2.0.3 to 2.0.4
…ig-filter Remove Config Filter module
…event-api-changed Update event API, editing series should reflect in changed date. DDFHER-132
In the dpl-react project, we migrated from `/holdings/v3` to `/holdingsLogistics/v1`. Refer to the pull request: danskernesdigitalebibliotek/dpl-react#1443. This change caused the `user-journey` Cypress test to fail.
The previous configuration was using release `2024.48.0`, but it must be switched back to `develop` to include the `/holdingsLogistics/v1` update. This adjustment is essential for other developers' work until the next release.
…mplementer-nyt-beholdnings-endpoint DDFHER-83 - Update Cypress fixtures to reflect the new `/holdingsLogistics/v1` API
# Conflicts: # web/modules/custom/dpl_event/src/EventWrapper.php
…ixes Redia XML fixes
Bumps the minor-js-dependencies group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 8.16.0 to 8.17.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.17.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 8.16.0 to 8.17.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.17.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-js-dependencies - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-js-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
When updating a user, we want to log the changes done - this is part of a security policy by DDF. For most fields, the old and new value gets logged, but others may be ignored, or declared on a meta-level (such as password).
…npm_and_yarn/minor-js-dependencies-263190dbf1 Bump the minor-js-dependencies group with 2 updates
…user-logging Logging custom DDF events, such as updates to users. DDFHER-150
…expand-event-api Expand event API to include `partners` as array string. DDFHER-119
…o-version Rolling back from incompatible go version
…4.49.0 Use release 2024.49.0 of design system and React components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.