Update BnfImporter to also import basic paragraphs. #1874
Merged
+228
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasben
force-pushed
the
bnf-text-paragraph
branch
from
1876f76 to
0dcfdbd
Compare
rasben
force-pushed
the
bnf-text-paragraph
branch
from
0dcfdbd to
0043146
Compare
rasben
force-pushed
the
bnf-text-paragraph
branch
from
0043146 to
ff928f9
Compare
Making some assumptions on how graphql_compose builds the links (as there is no way of doing it reverse, as far as I can see..), we build a query that looks up available fields, on paragraphs we support. This feels a bit dirty, but for now, until we've cleared how to deal with GraphQL schemas/codegen, it'll do. Only text_body and accordion paragraphs are imported.
rasben
force-pushed
the
bnf-text-paragraph
branch
from
ff928f9 to
99a1fd3
Compare
rasben
changed the title
xendk
approved these changes
Jan 2, 2025
| GRAPHQL; | ||
|
|
||
| // Loop through allowed paragraphs and add their structures. | ||
| foreach (self::ALLOWED_PARAGRAPHS as $graphBundle => $drupalBundle) { |
There was a problem hiding this comment.
I'd suggest to fold this out in a helper method that deals with the "inside" of the paragraphs section.
I think at the end we'll end up with a getQuery that just calls getFields which recursively generates the needed GraphQL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels a bit dirty, but for now, until we've cleared how to deal with GraphQL schemas/codegen, it'll do.
Only text_body paragraphs are imported.