Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFNEXT-645 - Update drupal/metatag from 2.0.2 to 2.1.0 #1903

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented Jan 2, 2025

Link to issue

https://reload.atlassian.net/browse/DDFNEXT-645 /
https://reload.atlassian.net/browse/DDFBRA-308

Description

This update introduces a new required setting: Trimming options.
The update sets this option to Trim the Meta Tag before the word on the given value by default and adds the following characters as delimiters: |.,-:;/+&([{"'.

Skærmbillede 2025-01-02 kl  13 25 49

Test

https://varnish.pr-1903.dpl-cms.dplplat01.dpl.reload.dk/admin/config/search/metatag/settings

Copy link
Contributor

@kasperg kasperg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

It would be nice with a Cypress test for this area.

@kasperg kasperg assigned kasperbirch1 and unassigned kasperg, xendk and rasben Jan 6, 2025
This update introduces a new required setting: `Trimming options`.
The update sets this option to `Trim the Meta Tag before the word on the given value` by default and adds the following characters as delimiters: `|.,-:;/+&([{"'`.
@kasperbirch1 kasperbirch1 force-pushed the DDFNEXT-645-opgrader-drupal-metatag-cms branch from b984ba2 to 5b237c3 Compare January 8, 2025 09:52
@kasperbirch1 kasperbirch1 merged commit aab7f08 into develop Jan 8, 2025
20 checks passed
@kasperbirch1 kasperbirch1 deleted the DDFNEXT-645-opgrader-drupal-metatag-cms branch January 8, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants