Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot round 2 #406

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Fix dependabot round 2 #406

merged 5 commits into from
Oct 11, 2023

Conversation

kasperg
Copy link
Contributor

@kasperg kasperg commented Oct 10, 2023

Description

This is a bunch fixes to improve our Dependabot workflow.

Please see the individual commits for additional commentary.

Otherwise workflows triggered by Dependabot will fail due to
insufficient resources when we try to publish translations to GitHub
Pages.
Otherwise workflows triggered by Dependabot will fail due to
insufficient resources when we try to create, update or delete an
environment/deployment corresponding to a pull request.
It should be safe to merge these as long as they follow semantic 
versioning.

Drupal Core is explicitly excluded as it has it's own versioning scheme
and is handled by other groups.
Up until now we have only seen proper Dependabot updates for GitHub 
Actions. It is the first package ecosystem in the file.

In the documentation as well as in our other repositories updates are
indented. Let us try to do this as well here to see if this can get
updates rolling.
The composer.json file is located under /dev-scripts. The documentation
suggests that the directory should be prefixed with a slash. We should
try to do so as well here.
@github-actions github-actions bot temporarily deployed to pr-406 October 10, 2023 19:24 Inactive
@spaceo spaceo removed their assignment Oct 11, 2023
Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kasperg kasperg merged commit 1cf0a4c into develop Oct 11, 2023
16 checks passed
@kasperg kasperg deleted the fix-dependabot-2 branch October 11, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants