Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create environment for testing: DDFLSBP-200 (Validation for Phone Numbers) #407

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented Oct 11, 2023

This will be fixed in #427

Link to issue

danskernesdigitalebibliotek/dpl-react#590

Description

Please include a short description of the suggested change and the reasoning behind the approach you have chosen.

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

Additional comments or questions

If you have any further comments or questions for the reviewer them please add them here.

@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-200-formvalidering-ingen-formvalidering-pa-felt-til-mobilnummer branch from c4639bc to 5f35af6 Compare October 11, 2023 12:51
@github-actions github-actions bot temporarily deployed to pr-407 October 11, 2023 12:52 Inactive
@github-actions github-actions bot temporarily deployed to pr-407 October 11, 2023 13:09 Inactive
@github-actions github-actions bot temporarily deployed to pr-407 October 12, 2023 08:50 Inactive
@github-actions github-actions bot temporarily deployed to pr-407 October 13, 2023 06:50 Inactive
@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-200-formvalidering-ingen-formvalidering-pa-felt-til-mobilnummer branch from 2cd094d to d17629e Compare October 16, 2023 08:59
@github-actions github-actions bot temporarily deployed to pr-407 October 16, 2023 08:59 Destroyed
@github-actions github-actions bot temporarily deployed to pr-407 October 16, 2023 09:00 Destroyed
@kasperbirch1 kasperbirch1 changed the title Create environment for testing: DDFLSBP-200 Create environment for testing: DDFLSBP-200 (Validation for Phone Numbers) Oct 16, 2023
@kasperbirch1 kasperbirch1 requested a review from spaceo October 16, 2023 09:08
@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-200-formvalidering-ingen-formvalidering-pa-felt-til-mobilnummer branch from d17629e to 0e123f0 Compare October 17, 2023 11:52
@github-actions github-actions bot temporarily deployed to pr-407 October 17, 2023 11:53 Destroyed
@kasperbirch1 kasperbirch1 force-pushed the DDFLSBP-200-formvalidering-ingen-formvalidering-pa-felt-til-mobilnummer branch from 0e123f0 to 0cb2404 Compare October 17, 2023 11:54
@github-actions github-actions bot temporarily deployed to pr-407 October 17, 2023 11:55 Destroyed
@github-actions github-actions bot temporarily deployed to pr-407 October 17, 2023 12:07 Destroyed
Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update description if you want this PR to be reviewed ;)

@spaceo spaceo removed their assignment Oct 18, 2023
@kasperbirch1 kasperbirch1 marked this pull request as draft October 19, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants