Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ereolen-homepage-url prop to all dpl-react apps #472

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

Adamik10
Copy link
Contributor

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-160
https://reload.atlassian.net/browse/DDFLSBP-199

Description

Adding url data prop for ereol-homepage for this PR.

Screenshot of the result

n/a

Additional comments or questions

n/a

@github-actions github-actions bot temporarily deployed to pr-472 November 15, 2023 10:39 Destroyed
Copy link
Contributor

@kasperg kasperg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work adding this to the CMS. I have a quibble regarding how much we expect libraries to configure on their own for the site to work.

@Adamik10 Adamik10 changed the base branch from develop to demo_2023-48-0 November 20, 2023 11:09
@Adamik10 Adamik10 requested a review from kasperg November 20, 2023 11:56
@github-actions github-actions bot temporarily deployed to pr-472 November 20, 2023 12:02 Destroyed
@github-actions github-actions bot temporarily deployed to pr-472 November 20, 2023 12:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-472 November 20, 2023 12:16 Destroyed
Copy link
Contributor

@kasperg kasperg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1. LGTM

@Adamik10 Adamik10 merged commit 1e68f18 into demo_2023-48-0 Nov 27, 2023
15 checks passed
@Adamik10 Adamik10 deleted the add-ereol-homepage-url branch November 27, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants