Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ARM-compatible Docker images for better support on new Macs #479

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

kasperg
Copy link
Contributor

@kasperg kasperg commented Nov 17, 2023

Description

Docker will issue warnings when starting database and Wiremock images because they are not available for ARM architecture.

To address this we update to images which are.

For Wiremock the change matches what we already want to do for the React components in danskernesdigitalebibliotek/dpl-react@2cbb10f.

For the database image we explicitly have to change to a different image as Lagoon for whatever reason does not provide an ARM-compatible build for uselagoon/mariadb-drupal.

Switching to an image that is, uselagoon/mariadb-10.6-drupal, seems to be a good idea, so we are aware of what version of mariadb we are actually using.

Docker will issue warnings when starting database and Wiremock images
because they are not available for ARM architecture.

To address this we update to images which are.

For Wiremock the change matches what we already want to do for the React
components.

For the database image we explicitly have to change to a different image
as Lagoon for whatever reason does not provide an ARM-compatible build 
for uselagoon/mariadb-drupal. 

Switching to an image that is, uselagoon/mariadb-10.6-drupal, seems to
be a good idea, so we are aware of what version of mariadb we are
actually using.
@kasperg kasperg requested a review from spaceo November 17, 2023 11:20
@github-actions github-actions bot temporarily deployed to pr-479 November 17, 2023 11:20 Destroyed
@kasperg kasperg removed the request for review from spaceo November 17, 2023 11:45
@Dresse Dresse changed the base branch from develop to demo_2023-48-0 November 20, 2023 11:10
Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@spaceo spaceo removed their assignment Nov 20, 2023
@kasperg kasperg merged commit e9f3a46 into demo_2023-48-0 Nov 20, 2023
19 checks passed
@kasperg kasperg deleted the arm-compatible-images branch November 20, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants