Add event title
#512
Merged
Add event title
#512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
6b63222 to
b722a1a
Compare
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
b722a1a to
ff48308
Compare
kasperbirch1
changed the title
event title + Update the Article Module to enhance the handling of different content types
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
ff48308 to
63e1fac
Compare
Merged
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
63e1fac to
e36b307
Compare
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
e36b307 to
7db9634
Compare
kasperbirch1
changed the title
event title + Update the Article Module to enhance the handling of different content typesevent title
LasseStaus
reviewed
Dec 7, 2023
web/themes/custom/novel/templates/layout/node--event--full.html.twig
Outdated
Show resolved
Hide resolved
LasseStaus
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Very nice!
Jeg har et forslag til en ændring i template.
Så så jeg noget med stylingen, som kan relateres til dette commit i design systemet
Min foreslåede ændring er commenteret i dette pr i design system:
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
7db9634 to
8d9e887
Compare
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
8d9e887 to
cbd341b
Compare
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
cbd341b to
5e8f55e
Compare
added 'wrapper' classes to ensure the placement of the title and added inline comments to indicate where other elements should be in the future. DDFFORM-15.
kasperbirch1
force-pushed
the
DDFFORM-15-titel
branch
from
5e8f55e to
c4eed67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFFORM-15
Description
This pull request introduces necessary markup changes for displaying the event title on the event page.
Summary of Changes:
Screenshot of the result