Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translations to dpl react apps controller #561

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

Adamik10
Copy link
Contributor

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-245

Description

These translation strings were found when introducing this PR's sibling PR

order-digital-copy-feedback-borchk-user-no-longer-exist-on-agency-text
order-digital-copy-feedback-borchk-user-not-verified-text
order-digital-copy-feedback-error-municipalityagencyid-not-found-text
order-digital-copy-feedback-unknown-user-text

Screenshot of the result

n/a

Additional comments or questions

n/a

order-digital-copy-feedback-borchk-user-no-longer-exist-on-agency-text
order-digital-copy-feedback-borchk-user-not-verified-text
order-digital-copy-feedback-error-municipalityagencyid-not-found-text
order-digital-copy-feedback-unknown-user-text
@github-actions github-actions bot temporarily deployed to pr-561 December 16, 2023 15:46 Destroyed
@Dresse Dresse unassigned spaceo and Dresse Dec 16, 2023
Copy link
Contributor

@Dresse Dresse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot temporarily deployed to pr-561 December 19, 2023 10:14 Destroyed
Copy link
Contributor

@Dresse Dresse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stil LGTB 👍
But the base branch needs to be changed to the newest release/2024-1.0 branch I think? :)

@github-actions github-actions bot temporarily deployed to pr-561 December 19, 2023 12:31 Destroyed
@github-actions github-actions bot temporarily deployed to pr-561 December 19, 2023 13:08 Destroyed
@github-actions github-actions bot temporarily deployed to pr-561 December 19, 2023 13:28 Destroyed
@Adamik10 Adamik10 changed the base branch from release/2023-50-0 to demo/2024-1-0 December 20, 2023 14:09
@Adamik10 Adamik10 changed the base branch from demo/2024-1-0 to develop December 20, 2023 14:10
@Adamik10 Adamik10 merged commit 04d08db into develop Dec 20, 2023
21 checks passed
@Adamik10 Adamik10 deleted the add-missing-translations branch December 20, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants