DDFFORM 417 display opening hours #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDFFORM-417
This ensures that the paragraph cannot be selected for the content types Artciel and Page, as it should only be used on the content-type Branch DDFFORM-417
DDFFORM-417
This was referenced Apr 3, 2024
DDFFORM-417
LasseStaus
force-pushed
the
DDFFORM-417-display-opening-hours
branch
from
a8c038d to
cf10c6e
Compare
kasperg
approved these changes
Apr 4, 2024
LasseStaus
force-pushed
the
DDFFORM-417-display-opening-hours
branch
from
cf10c6e to
2693fa7
Compare
This is added to a new dpl_opening_hours.module file to keep paragraph context related to opening hours. This prepares the data necessary for the react app opening hours. DDFFORM-417
This is all generated from task dev:codegen:dpl-cms DDFFORM-417
LasseStaus
force-pushed
the
DDFFORM-417-display-opening-hours
branch
from
2693fa7 to
29c79fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
Jira: DDFFORM-417
This PR depends on two PRs.
Design system PR
React PR
Description
This PR adds a paragraph for displaying the openingHours for a branch.
It should only be possible to use this paragraph on the content type 'Branch'
Most of the logic is done in the react app, commits should explain what is being done here.
Screenshot of the result
Additional comments or questions
Consider if it is necessary to add more checks in the preprocess.
Consider if the branch_id is retrieved properly.