Introducing button box #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is meant for items that only should be shown on mobile
spaceo
changed the title
spaceo
force-pushed
the
DDFLSBP-57-mobilvisning-knap-til-forny-flere-vises-ikke
branch
from
31facfb to
78f35d3
Compare
Since we need the expression in different places besides modals we can generalise it
above the renew button on the loan list page on mobile devcices
spaceo
force-pushed
the
DDFLSBP-57-mobilvisning-knap-til-forny-flere-vises-ikke
branch
from
78f35d3 to
2c61224
Compare
Adamik10
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-57
Description
This PR introduces the button box and sticky button box concept.
The footer box classes were created in order to accomodate the sticky renewal button on the loan page when watching it on a mobile device.
The button box classes replaces the modal-loan__buttons classes, since button box is more generic and used not only in modals.
Screenshot of the result
button_loans.mov