Handling releases with versioned assets #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One for handling releases invoked by tagging. Another for PR changes. The original idea was to to make the pr create a tag which the other workflow would react upon. But that flow is not directly supported. The bundle script has been expanded to support writing a version file.
kasperg
reviewed
Dec 7, 2023
Of course we need fixed versions
Since the tagname comes from the branch name of the latest commit we cannot be sure of the format. So I am afraid of edge cases with weird chars.
spaceo
force-pushed
the
DDFLSBP-328-tagged-dependencies-for-better-release
branch
from
d63d6a2 to
224e8da
Compare
We want it also to happen to merges to eg. develop so there is no need to restrict it to PR's only. And Dependabot should not create release :)
So it reflects what it does ¯\_(ツ)_/¯
spaceo
force-pushed
the
DDFLSBP-328-tagged-dependencies-for-better-release
branch
from
224e8da to
49c26d4
Compare
spaceo
force-pushed
the
DDFLSBP-328-tagged-dependencies-for-better-release
branch
4 times, most recently
from
02bd9af to
eea1b5c
Compare
NPm Rejects non semver tags
spaceo
force-pushed
the
DDFLSBP-328-tagged-dependencies-for-better-release
branch
from
eea1b5c to
6f1854a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-328
Description
Splitting deployment into two workflows
One for handling releases invoked by tagging.
Another for PR changes.
The original idea was to to make the pr create a tag which the other workflow would react upon. But that flow is not directly supported.
The bundle script has been expanded to support writing a version file.