Adding 'Identity' CSS for missing event image
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFFORM-75-hovedbillede-til-arrangement
branch
from
13d65ca to
9d75a4e
Compare
|
Please look at the UI tests before assigning reviewers :) |
- Implement `%identity-placeholder` to set the background color and apply a bold border. - Introduce `image-credited__no-image` class that extends `%identity-placeholder`.
kasperbirch1
force-pushed
the
DDFFORM-75-hovedbillede-til-arrangement
branch
from
9d75a4e to
ffd072b
Compare
rasben
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFFORM-93
Description
This pull request introduces the "identity" CSS class to manage scenarios involving missing images.
%identity-placeholderclass, which sets the background color and adds a bold border.image-credited__no-image class, an extension of%identity-placeholder.height: autoproperty to img elements, ensuring the aspect ratio of images is maintained.Screenshot of the result