Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit focus styles for buttons #408

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

JacobArrow
Copy link
Contributor

@JacobArrow JacobArrow commented Dec 21, 2023

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-55

Description

To comply with the laws of WCAG, we need a distinctive style for focused buttons.
This needs to be an outline with at least 2px wideness, and a clear difference in contrast

Screenshot of the result

button focus

To comply with the laws of WCAG, we need a distinctive style for focused buttons.
This needs to be an outline with at least 2px wideness, and a clear difference in contrast
@JacobArrow JacobArrow changed the title Added focus explicit styles for buttons Added explicit focus styles for buttons Dec 21, 2023
@spaceo spaceo self-requested a review December 23, 2023 22:45
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JacobArrow JacobArrow merged commit 60d0cc8 into release/2024-1-0 Dec 27, 2023
8 checks passed
@JacobArrow JacobArrow deleted the DDFLSBP-55-button-focus branch December 27, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants