Encode inline SVGs #614
Merged
Encode inline SVGs #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperg
force-pushed
the
encode-inline-svgs
branch
4 times, most recently
from
95d99f2 to
28d5d51
Compare
When using an inline SVG it must be encoded. Otherwise browsers may choke on it due to unescaped characters like < and ". At the moment problem can be seen when the Chromatic/Cypress integration tries to generate pages with inline CSS. Without this process fails and CSS is never loaded. To address this we encode the inline CSS using https://yoksel.github.io/url-encoder/. A proper SCSS function to address this would be preferable but I could not find such a thing. We only have two actual instances of inline SVGs to for now it should be OK to just change these. The fact that this is a nice change is also indicated by the fact that we no longer have stylelint issues that has to be ignored.
kasperg
force-pushed
the
encode-inline-svgs
branch
from
28d5d51 to
2f8cb76
Compare
|
The Chromatic tests currently fail for an SVG. We need to fix this before this can be merged. |
The style element makes Chrome not render the background image. Also it is not really needed as a separate style element. Convert it to attributes on the element instead.
This has now been fixed. |
rasben
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using an inline SVG it must be encoded. Otherwise browsers may choke on it due to unescaped characters like < and ".
At the moment problem can be seen when the Chromatic/Cypress integration tries to generate pages with inline CSS. Without this process fails and CSS is never loaded.
To address this we encode the inline CSS using
https://yoksel.github.io/url-encoder/. A proper SCSS function to address this would be preferable but I could not find such a thing.
We only have a few actual instances of inline SVGs to for now it should be OK to just change these.
This is needed for danskernesdigitalebibliotek/dpl-cms#1333