Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb design. DDFFORM-608 #618

Merged
merged 2 commits into from
May 2, 2024
Merged

Breadcrumb design. DDFFORM-608 #618

merged 2 commits into from
May 2, 2024

Conversation

rasben
Copy link
Contributor

@rasben rasben commented May 2, 2024 •
edited
Loading

@rasben rasben force-pushed the breadcrumb-design branch 3 times, most recently from 370baab to 9d772ef Compare May 2, 2024 09:51
@rasben rasben mentioned this pull request May 2, 2024
Merged
@rasben rasben force-pushed the breadcrumb-design branch from 9d772ef to b8dd97d Compare May 2, 2024 10:55
LasseStaus
LasseStaus requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@LasseStaus LasseStaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Missing flex-wrap, and a row-gap or line-height for when breadcrumb exceeds a single line

LasseStaus
LasseStaus approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@LasseStaus LasseStaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 👍 💯

@rasben rasben force-pushed the breadcrumb-design branch from b8dd97d to 6ec76a7 Compare May 2, 2024 11:09
LasseStaus
LasseStaus approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@LasseStaus LasseStaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From header to breadcumb should be 24px as far as i can see, and the margin-top on article header is current 64, should be 56.

You can decide on the latter, but i would change the top margin

@rasben rasben merged commit 926b9b9 into release/hermod-14 May 2, 2024
8 checks passed
@rasben rasben deleted the breadcrumb-design branch May 2, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LasseStaus LasseStaus LasseStaus approved these changes

Assignees

@kasperg kasperg

@LasseStaus LasseStaus

@kasperbirch1 kasperbirch1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rasben @LasseStaus @kasperg @kasperbirch1