Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromatic deployment action, to only deploy when needed. #642

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

rasben
Copy link
Contributor

@rasben rasben commented May 28, 2024

Update Chromatic deployment action, to only deploy when needed.

Refactored the Chromatic deployment GitHub Action to enhance deployment
efficiency by ensuring actions only run when necessary.
Up until now, it triggered on every single push, regardless if the push
was made against an active pull request or not.

The workflow now triggers on push events for the main, develop, and
release/* branches, and on specific pull_request events. Added
concurrency control to prevent duplicate workflows from running
simultaneously by canceling in-progress actions if a new relevant event
occurs. These changes improve deployment efficiency, consistency, and
hopefully means we won't exceed the tokens as often.

https://reload.zulipchat.com/#narrow/stream/240325-DDF/topic/chromatic.20og.20push

Refactored the Chromatic deployment GitHub Action to enhance deployment
efficiency by ensuring actions only run when necessary.
Up until now, it triggered on every single push, regardless if the push
was made against an active pull request or not.

The workflow now triggers on push events for the main, develop, and
release/* branches, and on specific pull_request events. Added
concurrency control to prevent duplicate workflows from running
simultaneously by canceling in-progress actions if a new relevant event
occurs. These changes improve deployment efficiency, consistency, and
hopefully means we won't exceed the tokens as often.
@rasben rasben force-pushed the chromatic-action-tweak branch from b7d0e75 to 6ab7420 Compare May 28, 2024 07:20
Copy link
Contributor

@LasseStaus LasseStaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice change 👍

@rasben rasben merged commit 3ff56df into develop Jun 6, 2024
8 checks passed
@rasben rasben deleted the chromatic-action-tweak branch June 6, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants