Add new banner component
#651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFFORM-540-bannerparagraph
branch
2 times, most recently
from
9b943b1 to
e77f7c7
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Jun 1, 2024
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Jun 1, 2024
kasperbirch1
commented
Jun 1, 2024
kasperbirch1
force-pushed
the
DDFFORM-540-bannerparagraph
branch
from
e77f7c7 to
2eac008
Compare
kasperbirch1
force-pushed
the
DDFFORM-540-bannerparagraph
branch
from
2eac008 to
8017f32
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Jun 3, 2024
kasperbirch1
force-pushed
the
DDFFORM-540-bannerparagraph
branch
2 times, most recently
from
89a404b to
f12b323
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Jun 4, 2024
LasseStaus
reviewed
Jun 6, 2024
LasseStaus
reviewed
Jun 6, 2024
LasseStaus
reviewed
Jun 6, 2024
LasseStaus
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Good stuff, i have some suggestions you can consider.
I think it could be considered if a link is required. Maybe ddf wants the component to also be used without a link. This is potentially out-of-scope here since they didn't specify it, but i think its' worth asking if we haven't.
I'm unsure about the implementation of the image. By doing this, we use everything related to media-container, which has figures, fallbacks etc which might not be necessary.
I would suggest you consider setting the image as a backgrundImage directly inline instead, and simplify the html structure. This is also being done here. Maybe @rasben could chime in what he thinks about that.
I'd suggest you link to related PR's also for convenience 🚀
Good stuff with the underline!
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Jun 13, 2024
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Jun 13, 2024
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Jun 13, 2024
LasseStaus
force-pushed
the
DDFFORM-540-bannerparagraph
branch
3 times, most recently
from
a42d091 to
bb9a2e2
Compare
kasperg
approved these changes
Jun 20, 2024
LasseStaus
force-pushed
the
DDFFORM-540-bannerparagraph
branch
from
7b7773b to
55ef7b6
Compare
LasseStaus
force-pushed
the
DDFFORM-540-bannerparagraph
branch
from
55ef7b6 to
00e28b5
Compare
This component contains a required link and title. It can be used with a description and a background image to enhance visual appeal. The title field is a `ReactNode` where the `<u>` (underlined) tag has a custom underline SVG placed beneath it.
Replaced the fixed `margin-left` pixels in `banner-content` with a new layout wrapper `banner__spacing` for dynamic spacing.
Rename mixin to be more generic Enhance responsiveness of component simplify grid stacking DDFFORM-540
DDFFORM-540
MediaContainer / image credited is not being correctly used here. To avoid redundant markup we use backgroundImage inline instead. DDFFORM-540
LasseStaus
force-pushed
the
DDFFORM-540-bannerparagraph
branch
from
00e28b5 to
9a9e7c2
Compare
LasseStaus
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFFORM-540
Description
This pull request adds a new
bannercomponent that contains a required link and title. It can be used with a description and a background image to enhance visual appeal.The
titlefield is aReactNodewhere the (underline) tag has a custom underlined SVG placed beneath it.Screenshot of the result